panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1241146403
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -2133,31 +2133,147 @@ case class OctetLength(child: Expressio
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1196197681
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala:
##
@@ -516,6 +516,95 @@ class StringExpressionsSuite extends S
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1196188986
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -2134,30 +2134,145 @@ case class OctetLength(child: Expressio
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1196188986
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -2134,30 +2134,145 @@ case class OctetLength(child: Expressio
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1196113962
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -2134,30 +2134,145 @@ case class OctetLength(child: Expressio
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1195837984
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -2142,22 +2142,118 @@ case class OctetLength(child: Expressio
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1193849840
##
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##
@@ -180,6 +180,7 @@ object CheckConne
panbingkun commented on code in PR #41169:
URL: https://github.com/apache/spark/pull/41169#discussion_r1193837633
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -37,7 +37,6 @@
import static org.apache.spark.unsafe.Platform.*;
-
Review C