[GitHub] [spark] pengzhon-db commented on pull request #41318: [SPARK-43803] [SS] [CONNECT] Improve awaitTermination() to handle client disconnects

2023-06-08 Thread via GitHub
pengzhon-db commented on PR #41318: URL: https://github.com/apache/spark/pull/41318#issuecomment-1583565719 @HyukjinKwon can you help merge this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] pengzhon-db commented on pull request #41318: [SPARK-43803] [SS] [CONNECT] Improve awaitTermination() to handle client disconnects

2023-06-06 Thread via GitHub
pengzhon-db commented on PR #41318: URL: https://github.com/apache/spark/pull/41318#issuecomment-1580008365 @HyukjinKwon Could u review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [spark] pengzhon-db commented on pull request #41318: [SPARK-43803] [SS] [CONNECT] Improve awaitTermination() to handle client disconnects

2023-06-06 Thread via GitHub
pengzhon-db commented on PR #41318: URL: https://github.com/apache/spark/pull/41318#issuecomment-1579523627 > Left a few comments. Can we add unit test for this? What kind of unit test are you referring to? We have existing Spark connect awaittermination unit test. Right now we don't