[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

2023-04-12 Thread via GitHub
rangadi commented on code in PR #38384: URL: https://github.com/apache/spark/pull/38384#discussion_r1163659080 ## connector/protobuf/pom.xml: ## @@ -93,6 +93,7 @@ maven-shade-plugin false + true Review Comment: Oh, it is trying to

[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

2022-11-16 Thread GitBox
rangadi commented on code in PR #38384: URL: https://github.com/apache/spark/pull/38384#discussion_r1024692244 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala: ## @@ -155,21 +155,52 @@ private[sql] object ProtobufUtils extends

[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

2022-11-16 Thread GitBox
rangadi commented on code in PR #38384: URL: https://github.com/apache/spark/pull/38384#discussion_r1024614312 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala: ## @@ -155,21 +155,52 @@ private[sql] object ProtobufUtils extends

[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

2022-11-16 Thread GitBox
rangadi commented on code in PR #38384: URL: https://github.com/apache/spark/pull/38384#discussion_r1024518159 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala: ## @@ -155,21 +155,52 @@ private[sql] object ProtobufUtils extends

[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

2022-11-16 Thread GitBox
rangadi commented on code in PR #38384: URL: https://github.com/apache/spark/pull/38384#discussion_r1024513027 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala: ## @@ -155,21 +155,52 @@ private[sql] object ProtobufUtils extends

[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

2022-11-15 Thread GitBox
rangadi commented on code in PR #38384: URL: https://github.com/apache/spark/pull/38384#discussion_r1023371786 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/ProtobufUtils.scala: ## @@ -155,21 +155,52 @@ private[sql] object ProtobufUtils extends