[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1223638394 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -2445,10 +2451,24 @@ class SparkConnectPlanner(val

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1205890281 ## sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala: ## @@ -451,13 +451,17 @@ final class DataStreamWriter[T] private[sql](ds:

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1205870558 ## sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala: ## @@ -451,13 +451,17 @@ final class DataStreamWriter[T] private[sql](ds:

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1205870302 ## sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala: ## @@ -451,13 +451,17 @@ final class DataStreamWriter[T] private[sql](ds:

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1205846938 ## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/foreachWriterPacket.scala: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1197276979 ## connector/connect/common/src/main/protobuf/spark/connect/commands.proto: ## @@ -216,6 +216,7 @@ message WriteStreamOperationStart { message StreamingForeachWriter

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1197275368 ## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/foreachWriterPacket.scala: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1197276153 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -2386,10 +2393,26 @@ class SparkConnectPlanner(val

[GitHub] [spark] rangadi commented on a diff in pull request #41129: [SPARK-43133] Scala Client DataStreamWriter Foreach support

rangadi commented on code in PR #41129: URL: https://github.com/apache/spark/pull/41129#discussion_r1196819312 ## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/foreachWriterPacket.scala: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software