[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-21 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-523659026 @cloud-fan, do you want to close this since #25348 was merged?

[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-05 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-518363216 I think the approach in #25348 is the right way to move forward because it calls the v1

[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-05 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-518351200 > have a special version of the v2 Table interface (DataSourceV1Table), which can

[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-05 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-518293707 @cloud-fan, can you be more specific about what you are proposing for the v1 update and

[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-03 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-517950156 @brkyvz, then why does this add analyzer rules that convert v2 plans to v1 plans? If we

[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-02 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-517851087 @brkyvz, I don't understand. I thought the idea was not to use v1 plans, but to use the

[GitHub] [spark] rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API

2019-08-02 Thread GitBox
rdblue commented on issue #25291: [SPARK-28554][SQL] implement basic catalog functionalities for JDBC v2 with a DS v1 fallback API URL: https://github.com/apache/spark/pull/25291#issuecomment-517816946 @cloud-fan, why does this convert from v2 plans to v1 plans? I don't think that