[GitHub] [spark] rdblue commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-28 Thread GitBox
rdblue commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-635683658 I agree that if it is a misunderstanding, then a veto isn't binding. And the way to handle that situation is to discuss why the justification was based on a misunderstanding and

[GitHub] [spark] rdblue commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-26 Thread GitBox
rdblue commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-633641667 @cloud-fan, sorry for my confusion here. From the summary, I didn't realize that this actually added back the streaming modes using private interfaces and mistakenly thought you

[GitHub] [spark] rdblue commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-21 Thread GitBox
rdblue commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-632185172 This PR wasn't ready to review until late Monday where I am, and was merged less than a day later. I had also assumed that the fix would be in a separate PR, which is why I

[GitHub] [spark] rdblue commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-20 Thread GitBox
rdblue commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-631608137 @cloud-fan, please stop merging pull requests that have a standing [veto](https://www.apache.org/foundation/voting.html). It is better to ask for a review.