[GitHub] [spark] rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s()

2020-02-12 Thread GitBox
rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s() URL: https://github.com/apache/spark/pull/27544#issuecomment-585498805 BTW, just want to mention that, before this PR, on Apache Spark master

[GitHub] [spark] rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s()

2020-02-11 Thread GitBox
rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s() URL: https://github.com/apache/spark/pull/27544#issuecomment-585051287 Thank you all for your reviews! I'll open a backport PR for branch-3.0

[GitHub] [spark] rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s()

2020-02-11 Thread GitBox
rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s() URL: https://github.com/apache/spark/pull/27544#issuecomment-584978315 Thanks a lot for the quick review, @viirya ! (I noticed this when b

[GitHub] [spark] rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s()

2020-02-11 Thread GitBox
rednaxelafx commented on issue #27544: [SPARK-30795][SQL] Spark SQL codegen's code() interpolator should treat escapes like Scala's StringContext.s() URL: https://github.com/apache/spark/pull/27544#issuecomment-584969448 cc @viirya @hvanhovell @cloud-fan @maropu who have worked on this area