[GitHub] [spark] rednaxelafx commented on pull request #39518: [SPARK-41991][SQL] `CheckOverflowInTableInsert` should accept ExpressionProxy as child

2023-01-12 Thread GitBox
rednaxelafx commented on PR #39518: URL: https://github.com/apache/spark/pull/39518#issuecomment-1381080180 I did a search as well and I haven't found any other `Expression.withNewChildrenInternal()` implementations that have casts in them. Most scalar expressions are indeed only requiring

[GitHub] [spark] rednaxelafx commented on pull request #39518: [SPARK-41991][SQL] `CheckOverflowInTableInsert` should accept ExpressionProxy as child

2023-01-12 Thread GitBox
rednaxelafx commented on PR #39518: URL: https://github.com/apache/spark/pull/39518#issuecomment-1381033109 The fix sure works. I feel like polluting the `ExpressionProxy` into core expression implementation is unfortunate, but off the top of my head I don't have a better alternative