[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1487331617 Please see if this fix can be pulled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1483606678 Right. This is simple 1 file fix with addition of test case versus the other one which may involve number of files. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1478932824 Perhaps the following would be better solution. Instead of looking for star any UnresolvedFunction should have UnresolvedAlias. Any comments? `private[this] def alias(expr:

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1470374550 Can anyone tell me how I am getting this single quote in count expression. Attaching the picture. This can potentially cause problems down the lance where tree nodes are compared in the

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1468635397 > The auto-generated alias name is fragile and we are trying to improve it at #40126 > > Can you give some examples of how the new update changes the alias name? If it's not

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1464842147 > I think the test is easy to fix. It wants to test the aggregate function result, but not the generated alias, so we just change the testing query to add alias explicitly. > >

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1460579037 [7_Run Build modules sql - other tests.txt](https://github.com/apache/spark/files/10923393/7_Run.Build.modules.sql.-.other.tests.txt) -- This is an automated message from the

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1453976515 Any comments. Apparently having all expr as unresolvedAlias is not working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1453013580 @cloud-fan always using unresolvedAlias seems to be causing the sql-other module to fail. Will be reverting to the original fix of creating unresolvedAlias only for "*" or distinct.

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1451285915 Not sure why the suggested changes made the build fail in the catalyst,hive-thriftserver module and sql-other test module. 2023-03-01T22:23:36.6700903Z Error instrumenting

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1449133178 Is there anything else that I need to do for the fix to be accepted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] ritikam2 commented on pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

ritikam2 commented on PR #40116: URL: https://github.com/apache/spark/pull/40116#issuecomment-1446869584 Not sure how my checkins are causing javadoc genration error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the