[GitHub] [spark] sadikovi commented on pull request #36573: [SPARK-38829][SQL][FOLLOWUP] Add `PARQUET_TIMESTAMP_NTZ_ENABLED` configuration for `ParquetWrite.prepareWrite`

sadikovi commented on PR #36573: URL: https://github.com/apache/spark/pull/36573#issuecomment-1128408501 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] sadikovi commented on pull request #36573: [SPARK-38829][SQL][FOLLOWUP] Add `PARQUET_TIMESTAMP_NTZ_ENABLED` configuration for `ParquetWrite.prepareWrite`

sadikovi commented on PR #36573: URL: https://github.com/apache/spark/pull/36573#issuecomment-1128402353 I think I just forgot to be honest and I did not add a test for it so the bug slipped during the review. I think we should add a test for both v1 and v2 data sources to make sure it

[GitHub] [spark] sadikovi commented on pull request #36573: [SPARK-38829][SQL][FOLLOWUP] Add `PARQUET_TIMESTAMP_NTZ_ENABLED` configuration for `ParquetWrite.prepareWrite`

sadikovi commented on PR #36573: URL: https://github.com/apache/spark/pull/36573#issuecomment-1128394222 Can you link the code to highlight the inconsistency between v1 and v2 configuration? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sadikovi commented on pull request #36573: [SPARK-38829][SQL][FOLLOWUP] Add `PARQUET_TIMESTAMP_NTZ_ENABLED` configuration for `ParquetWrite.prepareWrite`

sadikovi commented on PR #36573: URL: https://github.com/apache/spark/pull/36573#issuecomment-1128390778 Can you add a test for this? What is "Pass GA"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to