srowen commented on a change in pull request #27015: [SPARK-30358][ML] ML
expose predictRaw and predictProbability
URL: https://github.com/apache/spark/pull/27015#discussion_r361675426
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
##########
@@ -198,7 +198,8 @@ class DecisionTreeRegressionModel private[ml] (
}
/** We need to update this function if we ever add other impurity measures.
*/
- protected def predictVariance(features: Vector): Double = {
+ @Since("3.0.0")
+ def predictVariance(features: Vector): Double = {
Review comment:
This is the only one I'm not so sure about. I don't know if it's that useful
or if it's well defined ... it's not a variance but some impurity measure,
which I suppose happens to be variance in the regressor's prediction at the
moment. Not super against it, but is it useful to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
