[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-21 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r474785562 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -350,7 +350,7 @@ class

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-20 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r474107068 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -350,7 +350,7 @@ class

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-18 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r472285893 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -350,7 +350,7 @@ class

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-18 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r472274203 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -329,7 +329,7 @@ class

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-18 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r472269548 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala ## @@ -136,7 +136,8 @@ object ArrayBasedMapData {

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-17 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r471574319 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala ## @@ -206,14 +206,14 @@ object

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-16 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r471125765 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ## @@ -314,7 +314,7 @@ trait Row extends Serializable { * * @throws

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-16 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r471125067 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -351,6 +351,18 @@ class

[GitHub] [spark] srowen commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-14 Thread GitBox
srowen commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r470793047 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -351,6 +351,18 @@ class