[GitHub] [spark] srowen commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase

2019-07-01 Thread GitBox
srowen commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase URL: https://github.com/apache/spark/pull/24996#issuecomment-507324488 I personally favor removing the old deprecated implementation. It's probably simpler, and 3.0 is the right

[GitHub] [spark] srowen commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase

2019-07-01 Thread GitBox
srowen commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase URL: https://github.com/apache/spark/pull/24996#issuecomment-507267400 Because `ProcessingTime` was deprecated in 2.2.0, I actually think it's fine and good to remove it for

[GitHub] [spark] srowen commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase

2019-06-29 Thread GitBox
srowen commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase URL: https://github.com/apache/spark/pull/24996#issuecomment-506999280 Why introduce a new abstraction? This is what `Trigger.ProcessingTime` is meant to be. Just move the