[GitHub] [spark] srowen commented on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML

2019-08-22 Thread GitBox
srowen commented on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML URL: https://github.com/apache/spark/pull/25383#issuecomment-523934405 Merged to master This is an automated message from

[GitHub] [spark] srowen commented on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML

2019-08-21 Thread GitBox
srowen commented on issue #25383: [SPARK-13677][ML] Implement Tree-Based Feature Transformation for ML URL: https://github.com/apache/spark/pull/25383#issuecomment-523558542 Yeah, I think setters shouldn't be exposed on model objects. Some changes in the past have fixed some of that.