[GitHub] [spark] srowen commented on pull request #38598: [SPARK-41097][CORE][SQL][SS][PROTOBUF] Remove redundant collection conversion base on Scala 2.13 code

2022-11-24 Thread GitBox
srowen commented on PR #38598: URL: https://github.com/apache/spark/pull/38598#issuecomment-1326580994 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] srowen commented on pull request #38598: [SPARK-41097][CORE][SQL][SS][PROTOBUF] Remove redundant collection conversion base on Scala 2.13 code

2022-11-23 Thread GitBox
srowen commented on PR #38598: URL: https://github.com/apache/spark/pull/38598#issuecomment-1325129369 Let me know when it seems ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] srowen commented on pull request #38598: [SPARK-41097][CORE][SQL][SS][PROTOBUF] Remove redundant collection conversion base on Scala 2.13 code

2022-11-16 Thread GitBox
srowen commented on PR #38598: URL: https://github.com/apache/spark/pull/38598#issuecomment-1317141191 These are probably fine. Some may be hold-overs from earlier versions of Scala. I'm slightly worried that in some cases they cause a copy and we actually _rely_ on that, though this is a