[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values

2023-03-02 Thread via GitHub
srowen commented on PR #40219: URL: https://github.com/apache/spark/pull/40219#issuecomment-1451982884 Merged to master/3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values

2023-03-01 Thread via GitHub
srowen commented on PR #40219: URL: https://github.com/apache/spark/pull/40219#issuecomment-1450932083 Hm, no looks like something else is wrong in even setting up the environment. Github issue? `Error: Error response from daemon: Get "https://ghcr.io/v2/": received unexpected HTTP statu

[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values

2023-03-01 Thread via GitHub
srowen commented on PR #40219: URL: https://github.com/apache/spark/pull/40219#issuecomment-1450161777 Simple is good. Indeed the smallest of changes can even break things. This looks good pending CI/CD tests -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values

2023-02-28 Thread via GitHub
srowen commented on PR #40219: URL: https://github.com/apache/spark/pull/40219#issuecomment-1449217153 Oh yeah, won't affect 3.3. A quick test like your proof of concept would be great indeed. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values

2023-02-28 Thread via GitHub
srowen commented on PR #40219: URL: https://github.com/apache/spark/pull/40219#issuecomment-1449190687 @dongjoon-hyun I'd like a second opinion - should we merge to 3.4 or 3.3? Reasonable fix I think and I'm a little concerned there could be some weird way this would expand some info it sho