[GitHub] [spark] srowen commented on pull request #41195: [SPARK-43534][BUILD] Add log4j-1.2-api and log4j-slf4j2-impl to classpath if active hadoop-provided

2023-05-20 Thread via GitHub
srowen commented on PR #41195: URL: https://github.com/apache/spark/pull/41195#issuecomment-1556043789 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] srowen commented on pull request #41195: [SPARK-43534][BUILD] Add log4j-1.2-api and log4j-slf4j2-impl to classpath if active hadoop-provided

2023-05-19 Thread via GitHub
srowen commented on PR #41195: URL: https://github.com/apache/spark/pull/41195#issuecomment-1554550499 Seems reasonable then. Let's just get the tests to run again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] srowen commented on pull request #41195: [SPARK-43534][BUILD] Add log4j-1.2-api and log4j-slf4j2-impl to classpath if active hadoop-provided

2023-05-17 Thread via GitHub
srowen commented on PR #41195: URL: https://github.com/apache/spark/pull/41195#issuecomment-1551701267 It seems weird that log4j 2 config works, if you add log4j 1.x. Maybe so, just trying to figure out if this is really what's going on and if we have to let log4j 1.x back in? because then

[GitHub] [spark] srowen commented on pull request #41195: [SPARK-43534][BUILD] Add log4j-1.2-api and log4j-slf4j2-impl to classpath if active hadoop-provided

2023-05-17 Thread via GitHub
srowen commented on PR #41195: URL: https://github.com/apache/spark/pull/41195#issuecomment-155142 Can you explain this more - your steps to reproduce require you to remove files from the build, and that causes the problem? but the JARs were there before you removed them. How does