srowen opened a new pull request #25485: [SPARK-28434][TESTS][ML] Fix values in 
dummy tree in DecisionTreeSuite
URL: https://github.com/apache/spark/pull/25485
 
 
   ### What changes were proposed in this pull request?
   
   Fix dummy tree created in decision tree tests to have actually consistent 
stats, so that it can be compared in tests more completely. The current one has 
values for, say, impurity that don't even match internally.
   
   With this, the tests can assert more about stats staying correct after load.
   
   ### Why are the changes needed?
   
   Fixes a TODO and improves the test slightly.
   
   ### Does this PR introduce any user-facing change?
   
   None
   
   ### How was this patch tested?
   
   Existing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to