[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-29 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r758708422 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java ## @@ -201,6 +202,28 @@ public

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-29 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r758120451 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,19 +53,50 @@ public

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-19 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r753433365 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,19 +53,46 @@ public

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r752544556 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,19 +53,46 @@ public

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r752516781 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,19 +53,46 @@ public

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r752461643 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@ -1,252 +1,275 @@

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-17 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r751663494 ## File path: sql/core/benchmarks/DataSourceReadBenchmark-results.txt ## @@ -1,252 +1,275 @@

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-17 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r751620303 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java ## @@ -470,6 +493,14 @@ public final int

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-17 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r751486236 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,20 +53,45 @@ public

[GitHub] [spark] sunchao commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-16 Thread GitBox
sunchao commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r750731539 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java ## @@ -179,6 +180,18 @@ public