sunchao commented on PR #35657:
URL: https://github.com/apache/spark/pull/35657#issuecomment-1088209873
Thank you so much @cloud-fan @dongjoon-hyun and @pan3793 @somani for the
review! esp. @cloud-fan for your valuable comments!
@dongjoon-hyun I updated the JIRA title & descriptio
sunchao commented on PR #35657:
URL: https://github.com/apache/spark/pull/35657#issuecomment-1086963569
Thanks @dongjoon-hyun , updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
sunchao commented on pull request #35657:
URL: https://github.com/apache/spark/pull/35657#issuecomment-1068189873
Thanks @cloud-fan. Yes in terms of framework change what you described is
right (plus the changes on deprecating existing code).
> I think the above should be sufficient
sunchao commented on pull request #35657:
URL: https://github.com/apache/spark/pull/35657#issuecomment-1067554812
@cloud-fan updated according to the discuss we had offline. Please take
another look when you get a chance. Thanks!
--
This is an automated message from the Apache Git Servic
sunchao commented on pull request #35657:
URL: https://github.com/apache/spark/pull/35657#issuecomment-1058397619
Gently ping @cloud-fan @viirya @dongjoon-hyun @c21 @rdblue @aokolnychyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
sunchao commented on pull request #35657:
URL: https://github.com/apache/spark/pull/35657#issuecomment-1051105659
cc @cloud-fan @viirya @dongjoon-hyun @c21 @rdblue while I'm still trying to
cover more tests, I think this PR is almost ready for review now, and I'd love
to get some feedback
