sunchao commented on PR #36697:
URL: https://github.com/apache/spark/pull/36697#issuecomment-1143869351
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
sunchao commented on PR #36697:
URL: https://github.com/apache/spark/pull/36697#issuecomment-1140327360
Hmm thinking more about this, I think maybe we should fail the analysis on
the write path, even if a V2 transform exist in the function catalog.
Otherwise, the write may fail at a later s
sunchao commented on PR #36697:
URL: https://github.com/apache/spark/pull/36697#issuecomment-1140132786
@pan3793 hmm how? that change is test only and I don't see any test failure
in the latest CI run
--
This is an automated message from the Apache Git Service.
To respond to the message,
sunchao commented on PR #36697:
URL: https://github.com/apache/spark/pull/36697#issuecomment-1139985698
I think that can be a separate PR for master only to support function
catalog on the write path.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sunchao commented on PR #36697:
URL: https://github.com/apache/spark/pull/36697#issuecomment-1139971681
@pan3793 [this
commit](https://github.com/sunchao/spark/commit/c2a97be651df747f4edf19f46f2c2d41cd89b230)
should help to fix the tests.
--
This is an automated message from the Apache G
sunchao commented on PR #36697:
URL: https://github.com/apache/spark/pull/36697#issuecomment-1139803476
Sure. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
