[GitHub] [spark] tgravescs commented on pull request #31496: [SPARK-34384][CORE] API cleanup for ResourceProfile

2021-02-18 Thread GitBox
tgravescs commented on pull request #31496: URL: https://github.com/apache/spark/pull/31496#issuecomment-781404497 can we please rename pr and Jira and update the description. It would be good for jira to have description as well.

[GitHub] [spark] tgravescs commented on pull request #31496: [SPARK-34384][CORE] API cleanup for ResourceProfile

2021-02-08 Thread GitBox
tgravescs commented on pull request #31496: URL: https://github.com/apache/spark/pull/31496#issuecomment-775643486 The API as you state is Evolving and that is on purpose so we can extend and change as people use it and we learn more. I'm happy to hear the feedback and improve the API

[GitHub] [spark] tgravescs commented on pull request #31496: [SPARK-34384][CORE] API cleanup for ResourceProfile

2021-02-08 Thread GitBox
tgravescs commented on pull request #31496: URL: https://github.com/apache/spark/pull/31496#issuecomment-775276262 I'd really like to express my concern over this PR. There is a reason we go through a SPIP process and review the API's during design and PRs. Many things were discussed,

[GitHub] [spark] tgravescs commented on pull request #31496: [SPARK-34384][CORE] API cleanup for ResourceProfile

2021-02-08 Thread GitBox
tgravescs commented on pull request #31496: URL: https://github.com/apache/spark/pull/31496#issuecomment-775257493 I'm -1 for any changes here except maybe docs... it is way to late in the release to be changing api's. This was reviewed and went in. We have already put out an RC