[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1070214616 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1070214567 ## sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala: ## @@ -1314,6 +1314,78 @@ class PlannerSuite extends SharedSparkSession with

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1070214330 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069667682 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069636737 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069638822 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -205,8 +200,10 @@ trait UnaryNode extends LogicalPlan with

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069636737 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069618754 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069586074 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069574256 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala: ## @@ -205,8 +200,10 @@ trait UnaryNode extends LogicalPlan with

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069550840 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] ulysses-you commented on a diff in pull request #39556: [WIP][SPARK-42049][SQL] Improve AliasAwareOutputExpression

2023-01-13 Thread GitBox
ulysses-you commented on code in PR #39556: URL: https://github.com/apache/spark/pull/39556#discussion_r1069547803 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/AliasAwareOutputExpression.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software