[GitHub] [spark] ulysses-you commented on a diff in pull request #41407: [SPARK-43900][SQL] Support optimize skewed partitions even if introduce extra shuffle

2023-06-07 Thread via GitHub
ulysses-you commented on code in PR #41407: URL: https://github.com/apache/spark/pull/41407#discussion_r1222359355 ## sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/simpleCosting.scala: ## @@ -36,22 +36,37 @@ case class SimpleCost(value: Long) extends Cost { }

[GitHub] [spark] ulysses-you commented on a diff in pull request #41407: [SPARK-43900][SQL] Support optimize skewed partitions even if introduce extra shuffle

2023-06-05 Thread via GitHub
ulysses-you commented on code in PR #41407: URL: https://github.com/apache/spark/pull/41407#discussion_r1218787943 ## sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewInRebalancePartitions.scala: ## @@ -92,9 +93,21 @@ object

[GitHub] [spark] ulysses-you commented on a diff in pull request #41407: [SPARK-43900][SQL] Support optimize skewed partitions even if introduce extra shuffle

2023-06-04 Thread via GitHub
ulysses-you commented on code in PR #41407: URL: https://github.com/apache/spark/pull/41407#discussion_r1217406788 ## sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala: ## @@ -104,7 +104,10 @@ case class AdaptiveSparkPlanExec(