[GitHub] [spark] vanzin commented on issue #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-11 Thread GitBox
vanzin commented on issue #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#issuecomment-552669794 Merging to master. This

[GitHub] [spark] vanzin commented on issue #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-05 Thread GitBox
vanzin commented on issue #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#issuecomment-550091776 I added those annotations because I hit errors when I was modifying the SHS to use the

[GitHub] [spark] vanzin commented on issue #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper

2019-11-05 Thread GitBox
vanzin commented on issue #26397: [SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper URL: https://github.com/apache/spark/pull/26397#issuecomment-549909219 Why didn't unit tests catch this? (Or maybe: add a unit test?)