viirya commented on a change in pull request #27175: 
[SPARK-30312][SQL][FOLLOWUP] Preserve path permission and acl when truncate 
table
URL: https://github.com/apache/spark/pull/27175#discussion_r365535920
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
 ##########
 @@ -2052,7 +2052,7 @@ abstract class DDLSuite extends QueryTest with 
SQLTestUtils {
 
           val fileStatus2 = fs.getFileStatus(tablePath)
           if (ignore) {
-            assert(fileStatus2.getPermission().toString() == "rwxr-xr-x")
+            assert(fileStatus2.getPermission().toString() != "rwxrwxrwx")
 
 Review comment:
   This is a loose condition. I think it is rarely to have default file 
permission as `rwxrwxrwx`. Another option is not to check permission when 
`ignore` is true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to