[GitHub] [spark] viirya commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

viirya commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524429611 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object PushPredicateThroughJo

[GitHub] [spark] viirya commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

viirya commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523447490 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt ## @@ -1,5 +1,5 @@ == Physical Plan == -TakeOrderedAnd

[GitHub] [spark] viirya commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

viirya commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523444101 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,21 @@ object PushPredicateThroughJo

[GitHub] [spark] viirya commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

viirya commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523444101 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,21 @@ object PushPredicateThroughJo

[GitHub] [spark] viirya commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

viirya commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r523389535 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,21 @@ object PushPredicateThroughJo