[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
viirya commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571843989 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-05 Thread GitBox
viirya commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571178250 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-05 Thread GitBox
viirya commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571177849 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -81,7 +80,7 @@ case class HashAggregateExec(

[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-05 Thread GitBox
viirya commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571176503 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class