[GitHub] [spark] viirya commented on a change in pull request #33082: [SPARK-35886][SQL] CodeGenerator.getLocalInputVariableValues should handle case that expression match SubExprEliminationState but

2021-06-26 Thread GitBox
viirya commented on a change in pull request #33082: URL: https://github.com/apache/spark/pull/33082#discussion_r659221432 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ## @@ -1766,19 +1766,20 @@ object

[GitHub] [spark] viirya commented on a change in pull request #33082: [SPARK-35886][SQL] CodeGenerator.getLocalInputVariableValues should handle case that expression match SubExprEliminationState but

2021-06-26 Thread GitBox
viirya commented on a change in pull request #33082: URL: https://github.com/apache/spark/pull/33082#discussion_r659221432 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ## @@ -1766,19 +1766,20 @@ object