[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2023-04-20 Thread via GitHub
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r1172167784 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager:

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2023-04-18 Thread via GitHub
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r1170529644 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager:

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2023-04-18 Thread via GitHub
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r1170527110 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager:

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2022-09-15 Thread GitBox
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r972576281 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -247,7 +247,28 @@ case class DropTableCommand( } else if (ifExists) { //

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2022-09-15 Thread GitBox
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r972575165 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -247,7 +247,28 @@ case class DropTableCommand( } else if (ifExists) { //

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2022-09-15 Thread GitBox
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r972574338 ## sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala: ## @@ -159,11 +159,51 @@ class CacheManager extends Logging with AdaptiveSparkPlanHelper {

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2022-09-15 Thread GitBox
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r972453705 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala: ## @@ -244,3 +246,9 @@ case class ResolvedIdentifier( identifier:

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2022-09-15 Thread GitBox
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r972452739 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -247,7 +247,28 @@ case class DropTableCommand( } else if (ifExists) { //

[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

2022-09-15 Thread GitBox
viirya commented on code in PR #37879: URL: https://github.com/apache/spark/pull/37879#discussion_r972437078 ## sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala: ## @@ -159,11 +159,51 @@ class CacheManager extends Logging with AdaptiveSparkPlanHelper {