viirya commented on code in PR #37896:
URL: https://github.com/apache/spark/pull/37896#discussion_r973528716
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -1588,10 +1587,9 @@ class SessionCatalog(
TableFunctionRegistry.builtin.functionExists(name)
}
- protected[sql] def failFunctionLookup(
Review Comment:
Hmm, where do we set `cause`? As I see, we always call `failFunctionLookup`
without `cause` (except for the test case).
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala:
##########
@@ -74,19 +74,17 @@ case class NoSuchPartitionException(
case class NoSuchPermanentFunctionException(db: String, func: String)
extends AnalysisException(s"Function '$func' not found in database '$db'")
-case class NoSuchFunctionException(
- override val message: String,
- override val cause: Option[Throwable])
- extends AnalysisException(message, cause = cause) {
+case class NoSuchFunctionException(override val message: String)
+ extends AnalysisException(message) {
- def this(db: String, func: String, cause: Option[Throwable] = None) = {
+ def this(db: String, func: String) = {
this(s"Undefined function: '$func'. " +
s"This function is neither a registered temporary function nor " +
Review Comment:
nit:
```suggestion
"This function is neither a registered temporary function nor " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
