[GitHub] [spark] viirya edited a comment on pull request #29807: [WIP][SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-21 Thread GitBox
viirya edited a comment on pull request #29807: URL: https://github.com/apache/spark/pull/29807#issuecomment-695811872 > > For this case, seem we still need to handle Physical plan level > > ``` > > == Optimized Logical Plan == > Project [c1#1, CASE WHEN

[GitHub] [spark] viirya edited a comment on pull request #29807: [WIP][SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-20 Thread GitBox
viirya edited a comment on pull request #29807: URL: https://github.com/apache/spark/pull/29807#issuecomment-695811872 > > For this case, seem we still need to handle Physical plan level > > ``` > > == Optimized Logical Plan == > Project [c1#1, CASE WHEN

[GitHub] [spark] viirya edited a comment on pull request #29807: [WIP][SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-19 Thread GitBox
viirya edited a comment on pull request #29807: URL: https://github.com/apache/spark/pull/29807#issuecomment-695526440 @dongjoon-hyun Thanks for pinging me. Hmm, this is actually related to what we are working on SPARK-32943. We should not do it at physical plan level. We plan to tackle