[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-650014523 Hi, @dongjoon-hyun , I'm sorry , the result of maven compile seems OK after I change a computer. This is an

[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646469772 Update PR, and leave the shade plugin in. The test jar is need if I want to compile some other spark modules(eg. mllib ) individually.

[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646414088 Hi @srowen, I have compared the compilation results with and without shade plugin. Their result classes are the same. So I don't think we need to keep shade plugin anymore.