[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-11 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r870855910 ## python/pyspark/pandas/groupby.py: ## @@ -2228,6 +2299,20 @@ def tail(self, n: int = 5) -> FrameLike: 65 98 Name: b,

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869454838 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869460337 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869458670 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869458670 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869454838 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869454838 ## python/pyspark/pandas/groupby.py: ## @@ -2121,11 +2121,22 @@ def _limit(self, n: int, asc: bool) -> FrameLike: ) ) -sdf =

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing

2022-05-10 Thread GitBox
xinrong-databricks commented on code in PR #36464: URL: https://github.com/apache/spark/pull/36464#discussion_r869421364 ## python/pyspark/pandas/tests/test_groupby.py: ## @@ -2538,40 +2538,19 @@ def test_head(self): ) psdf = ps.from_pandas(pdf) -