xuanyuanking commented on a change in pull request #28607:
URL: https://github.com/apache/spark/pull/28607#discussion_r431873551
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
##########
@@ -132,6 +135,16 @@ trait StateStoreWriter extends StatefulOperator { self:
SparkPlan =>
}.toMap
}
+ protected def applyRemovingRowsOlderThanWatermark(
+ iter: Iterator[InternalRow],
+ predicate: BasePredicate): Iterator[InternalRow] = {
+ iter.filter { row =>
+ val filteredIn = !predicate.eval(row)
Review comment:
nit: little confusing of the variable naming here, maybe use a name
related with watermark? `inWatermark`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
