xuanyuanking opened a new pull request #26444: [SPARK-29807][SQL] Rename 
"spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled"
URL: https://github.com/apache/spark/pull/26444
 
 
   ### What changes were proposed in this pull request?
   Rename config "spark.sql.ansi.enabled" to 
"spark.sql.dialect.spark.ansi.enabled"
   
   ### Why are the changes needed?
   The relation between "spark.sql.ansi.enabled" and "spark.sql.dialect" is 
confusing, since the "PostgreSQL" dialect should contain the features of 
"spark.sql.ansi.enabled".
   
   To make things clearer, we can rename the "spark.sql.ansi.enabled" to 
"spark.sql.dialect.spark.ansi.enabled", thus the option 
"spark.sql.dialect.spark.ansi.enabled" is only for Spark dialect.
   
   For the casting and arithmetic operations, runtime exceptions should be 
thrown if "spark.sql.dialect" is "spark" and 
"spark.sql.dialect.spark.ansi.enabled" is true or "spark.sql.dialect" is 
PostgresSQL.
   
   
   ### Does this PR introduce any user-facing change?
   Yes, the config name changed.
   
   
   ### How was this patch tested?
   Existing UT.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to