[GitHub] [spark] yaooqinn commented on pull request #30586: [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results

2020-12-07 Thread GitBox
yaooqinn commented on pull request #30586: URL: https://github.com/apache/spark/pull/30586#issuecomment-739938357 > After a second thought, although char/varchar is kind of hidden before 3.1, it's still possible for users to use it already. @yaooqinn can we create a followup PR to add a

[GitHub] [spark] yaooqinn commented on pull request #30586: [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results

2020-12-06 Thread GitBox
yaooqinn commented on pull request #30586: URL: https://github.com/apache/spark/pull/30586#issuecomment-739742054 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn commented on pull request #30586: [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results

2020-12-06 Thread GitBox
yaooqinn commented on pull request #30586: URL: https://github.com/apache/spark/pull/30586#issuecomment-739493842 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn commented on pull request #30586: [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results

2020-12-04 Thread GitBox
yaooqinn commented on pull request #30586: URL: https://github.com/apache/spark/pull/30586#issuecomment-739130357 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn commented on pull request #30586: [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results

2020-12-04 Thread GitBox
yaooqinn commented on pull request #30586: URL: https://github.com/apache/spark/pull/30586#issuecomment-738973425 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] yaooqinn commented on pull request #30586: [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results

2020-12-04 Thread GitBox
yaooqinn commented on pull request #30586: URL: https://github.com/apache/spark/pull/30586#issuecomment-738805019 > @yaooqinn maybe we should use `char/varchar` instead of `char-like` to be clear. updated, pr title/description and the code