[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-28 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1695832483 The example in PR desc prints too many infrequently used characters I apologize for any confusion caused. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-28 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1695803037 https://github.com/apache/spark/pull/42674/files#diff-525465a6c6c1382bf8165da748522ec2387581ebd397fe25f5aa72107a45752aR119-R120, All the characters are here. In the PR description

[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-27 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1695053749 thanks @srowen @gengliangwang @sarutak @HyukjinKwon @dongjoon-hyun, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-27 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1694942009 > The second example just shows <> which can't the 'right' version of whatever this is It's the source code version, the rendered HTML. > What happened to the garbled text

[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-27 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1694869333 Hi @srowen, it actually removes double-escaping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-25 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1693602186 Thank you, @dongjoon-hyun. I have made the necessary updates to the PR based on your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] yaooqinn commented on pull request #42674: [SPARK-44960][UI] Unescape and consist error summary across UI pages

2023-08-25 Thread via GitHub
yaooqinn commented on PR #42674: URL: https://github.com/apache/spark/pull/42674#issuecomment-1693487193 cc @sarutak @HyukjinKwon @cloud-fan @dongjoon-hyun, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR