[GitHub] [spark] zhengruifeng commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
zhengruifeng commented on a change in pull request #27978: URL: https://github.com/apache/spark/pull/27978#discussion_r417048353 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/Selector.scala ## @@ -0,0 +1,391 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] zhengruifeng commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
zhengruifeng commented on a change in pull request #27978: URL: https://github.com/apache/spark/pull/27978#discussion_r417048353 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/Selector.scala ## @@ -0,0 +1,391 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] zhengruifeng commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector

2020-04-28 Thread GitBox
zhengruifeng commented on a change in pull request #27978: URL: https://github.com/apache/spark/pull/27978#discussion_r417042961 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/FValueSelector.scala ## @@ -154,111 +45,72 @@ private[feature] trait