[GitHub] [spark] zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-23 Thread GitBox
zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-533978563 Thank you @srowen @dongjoon-hyun !

[GitHub] [spark] zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-20 Thread GitBox
zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-533439453 `master / Build Spark with JDK 11 and hadoop-3.2 (pull_request) Fai` this check fails, do

[GitHub] [spark] zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532966941 retest this please This is

[GitHub] [spark] zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold

2019-09-18 Thread GitBox
zhengruifeng commented on issue #25829: [SPARK-29144][ML] Binarizer handle sparse vectors incorrectly with negative threshold URL: https://github.com/apache/spark/pull/25829#issuecomment-532655598 Just notice that existing ML algs deal with sparse dataset in a different way from