[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-11 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-552701738 Thanks for reviewing! @dongjoon-hyun @srowen This is an

[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-11 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-552362856 retest this please This is an automated message from the Apache

[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-10 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-552173400 retest this please This is an automated message from the Apache

[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-08 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-552066730 @huaxingao Yes, the py side should be updated too. This is an

[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-08 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-552066653 retest this please This is an automated message from the Apache

[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-08 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-552066603 @srowen Yes, I updated them in the second commit. BTW, I added toString method for evluatores/tunining/features impls

[GitHub] [spark] zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method

2019-11-08 Thread GitBox
zhengruifeng commented on issue #26439: [SPARK-29801][ML] ML models unify toString method URL: https://github.com/apache/spark/pull/26439#issuecomment-551663482 For example, KMeansModel.toString should expose some basice information like LoR, but it only contains Estimator's uid now.