[GitHub] [spark] zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

2020-02-24 Thread GitBox
zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]" URL: https://github.com/apache/spark/pull/27487#issuecomment-590662436 @viirya Yes, this is to revert on branch-3.0 too. I am go to revert it on 3.0. Thanks for pointing it out!

[GitHub] [spark] zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

2020-02-07 Thread GitBox
zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]" URL: https://github.com/apache/spark/pull/27487#issuecomment-583699847 @srowen Never mind, I should have maken more perfermance tests. Maybe we should do such refactors only when we have

[GitHub] [spark] zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

2020-02-07 Thread GitBox
zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]" URL: https://github.com/apache/spark/pull/27487#issuecomment-583677175 Merged to master This is an automated message from

[GitHub] [spark] zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

2020-02-07 Thread GitBox
zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]" URL: https://github.com/apache/spark/pull/27487#issuecomment-583363362 cc @mengxr @WeichenXu123 @srowen This is an

[GitHub] [spark] zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

2020-02-07 Thread GitBox
zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]" URL: https://github.com/apache/spark/pull/27487#issuecomment-583279317 retest this please This is an automated message

[GitHub] [spark] zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

2020-02-06 Thread GitBox
zhengruifeng commented on issue #27487: Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]" URL: https://github.com/apache/spark/pull/27487#issuecomment-583233200 @dongjoon-hyun There is some test and discussion in https://github.com/apache/spark/pull/27374, I also update the