zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-725847488
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-724482556
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-723879005
@mengxr I will update this PR after:
1, naming the parameter
2, choice of default value: it looks like we can adopt 1MB for both sparse
and dense cases. If so, I will
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-722762550
@mengxr Thanks for reviewing!
> Does your benchmark code count pre-processing time?
yes, pre-processing time is taken into account.
> Could you paste your
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-720851384
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-717647271
also ping @srowen
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-716252855
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-709713528
> Have you benchmark on other BLAS besides f2jBLAS ?
@WeichenXu123 both f2jBlas and openBlas were benchmarked, and recorded in
the result excel file.
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-708849480
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-708245249
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-707025789
@zero323 Yes, that is because the version installed via `sudo apt install
mypy` is too old (`0.560`).
`pip install mypy` works for me. Thank you!
zhengruifeng commented on pull request #30009:
URL: https://github.com/apache/spark/pull/30009#issuecomment-706824192
ping @WeichenXu123
@zero323 I send a new PR here, thanks for reviewing. I tried to verify
consistency of annotations locally, but the following cmd failed:
12 matches
Mail list logo