[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-06-01 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-852672261 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-06-01 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-852671590 Thanks @srowen for reviewing! I will make LinearRegression support virtual centering and then refactor some common blocks related to BLAS to simplify the impls. -- This

[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-06-01 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-852283210 friendly ping @srowen , I think it is ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-05-19 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-844037885 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-05-11 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-839467796 @srowen It should be safe to wait for BLAS related changes. I will keep this PR open. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-05-10 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-836484975 @srowen I think this PR is ready. Would you mind making a final review? As to refactoring some common block aggregator code, I will try to do this after LiR get changed in

[GitHub] [spark] zhengruifeng commented on pull request #32199: [SPARK-35100][ML] Refactor AFT - support virtual centering

2021-05-08 Thread GitBox
zhengruifeng commented on pull request #32199: URL: https://github.com/apache/spark/pull/32199#issuecomment-835214415 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci