zhengruifeng commented on PR #39499: URL: https://github.com/apache/spark/pull/39499#issuecomment-1379668005
@dongjoon-hyun good question. `range` in Connect has the same signature as the PySpark's one, which should only accept intergers. But PySpark's implementation doesn't check the input type https://github.com/apache/spark/blob/56c7cf33929d7d42b7d299c0bb7e895963241214/python/pyspark/sql/session.py#L788-L796 and in some cases / tests, the floats are used, like `range(10e10)`. We might need to update the typing for both Connect and PySpark in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
