[GitHub] [spark] zwangsheng commented on pull request #40118: [SPARK-26365][K8S] In kuberentes cluster mode, spark submit should pass driver exit code

2023-06-27 Thread via GitHub
zwangsheng commented on PR #40118: URL: https://github.com/apache/spark/pull/40118#issuecomment-1610487468 > Just following back up, @zwangsheng do you have cycles? Thanks for watching this, sry to be late. I added unit test for `LoggingPodStatusWatcher` and fixed comments, would you

[GitHub] [spark] zwangsheng commented on pull request #40118: [SPARK-26365][K8S] In kuberentes cluster mode, spark submit should pass driver exit code

2023-03-28 Thread via GitHub
zwangsheng commented on PR #40118: URL: https://github.com/apache/spark/pull/40118#issuecomment-1487916674 > Overall I like it, but I would want to see a unit test (does not need to go all the way to exit but something to show that the code would match). Thanks for your review.

[GitHub] [spark] zwangsheng commented on pull request #40118: [SPARK-26365][K8S] In kuberentes cluster mode, spark submit should pass driver exit code

2023-03-21 Thread via GitHub
zwangsheng commented on PR #40118: URL: https://github.com/apache/spark/pull/40118#issuecomment-1477559688 Hello @dongjoon-hyun @holdenk , please help review this PR, given that there is a lot of user feedback on JIRA about this issue -- This is an automated message from the Apache Git