[GitHub] mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn

2018-12-14 Thread GitBox
mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn URL: https://github.com/apache/spark/pull/23285#issuecomment-447268395 @HeartSaVioR I am just telling you what is my experience: I remember in one of my very first work

[GitHub] mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn

2018-12-13 Thread GitBox
mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn URL: https://github.com/apache/spark/pull/23285#issuecomment-446893251 @HeartSaVioR I'd rather say that `withColumns` can be easily done as well using select. So I am not

[GitHub] mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn

2018-12-12 Thread GitBox
mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn URL: https://github.com/apache/spark/pull/23285#issuecomment-446546121 the test failure shows a potential regression due to this patch I hadn't thought of. Collapsing the

[GitHub] mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn

2018-12-11 Thread GitBox
mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn URL: https://github.com/apache/spark/pull/23285#issuecomment-446230611 retest this please This is an

[GitHub] mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn

2018-12-11 Thread GitBox
mgaido91 commented on issue #23285: [SPARK-26224][SQL] Avoid creating many project on subsequent calls to withColumn URL: https://github.com/apache/spark/pull/23285#issuecomment-446169638 cc @cloud-fan @viirya This is an