Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
@dhruve there are conflicts in branch-2.0, if you want it there, could you
open a separate PR with the conflicts resolved?
---
If your project is set up for it, you can reply to this email and have
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
Merging to master / 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/13061
@vanzin, @tgravescs can we merge these in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59972/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59972/consoleFull)**
for PR 13061 at commit
[`11cef41`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59972/consoleFull)**
for PR 13061 at commit
[`11cef41`](https://github.com/apache/spark/commit/1
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
The test failures all seem unrelated, but, just in case: retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59963/consoleFull)**
for PR 13061 at commit
[`11cef41`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59963/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59963/consoleFull)**
for PR 13061 at commit
[`11cef41`](https://github.com/apache/spark/commit/1
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/13061
jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59959/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59959/consoleFull)**
for PR 13061 at commit
[`f3b6fbc`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59959/consoleFull)**
for PR 13061 at commit
[`f3b6fbc`](https://github.com/apache/spark/commit/f
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/13061
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/13061
Agreed its a minor. Have made the change now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
> Aren't we already doing that
No, you're throwing a generic exception that doesn't explain what's wrong.
None of the existing errors say "properties file not found", which is what a
null wo
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/13061
Aren't we already doing that. The generic catch would display the error
message and also the exception that caused it. Having an extra check isn't
going to add more value here.
---
If your project
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
> Feel that it would be better to error out rather than running an unknown
version
I meant a null check so you could throw a proper exception instead of a
generic `NullPointerException`.
-
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/13061
Fixed the minor nits. Feel that it would be better to error out rather than
running an unknown version of the framework, so haven't included the null check
for ```resourceStream```.
---
If your pro
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
Two nits that I missed before and this is good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59934/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59934/consoleFull)**
for PR 13061 at commit
[`031e5b0`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59934/consoleFull)**
for PR 13061 at commit
[`031e5b0`](https://github.com/apache/spark/commit/0
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/13061
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/13061
Test failure is unrelated. kicking again.
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59914/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13061
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59914/consoleFull)**
for PR 13061 at commit
[`031e5b0`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13061
**[Test build #59914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59914/consoleFull)**
for PR 13061 at commit
[`031e5b0`](https://github.com/apache/spark/commit/0
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user dhruve commented on the issue:
https://github.com/apache/spark/pull/13061
Cool. Thanks for reviewing the changes. Once this gets merged, I will file
a JIRA for the refactoring.
This one's been open for quite some time now.
---
If your project is set up for it,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
Any refactoring can be done separately, the current change is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/13061
Last message was a minute too late, so LGTM then.
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/13061
In the short-term we should definitely make the REPL welcome message
consistent. Could you consolidate it with the conflict resolution? I don't
think there are many changes required. However I'm al
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/13061
Sorry to bother you again and after a so long delay, however I just found
another minor style bug
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13061
Seems like Jakob is ok with the current code; @dhruve could you resolve
conflicts so we can merge this? Sorry for the delay.
---
If your project is set up for it, you can reply to this email and hav
42 matches
Mail list logo
