[GitHub] spark issue #13218: [SPARK-15440] [Core] [Deploy] Add CSRF Filter for REST A...

2016-07-04 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/13218 Updated PR at #14052 , close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13218: [SPARK-15440] [Core] [Deploy] Add CSRF Filter for REST A...

2016-06-17 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/13218 I can see there is fear of breaking things, especially with third party clients. There's also the risk of cross-version submissions; the REST API is meant to be stable enough for backwards

[GitHub] spark issue #13218: [SPARK-15440] [Core] [Deploy] Add CSRF Filter for REST A...

2016-06-16 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/13218 @andrewor14 might be able to comment on compatibility; enabling this by default might cause previous spark-submit versions to not be able to submit to the newer server, although with the "major

[GitHub] spark issue #13218: [SPARK-15440] [Core] [Deploy] Add CSRF Filter for REST A...

2016-06-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/13218 Just quickly go through the PR. I think we can add an option to enable CSRF protection and by default it could be false so that we don't introduce incompatibility and break the existing application.