Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/13285
Merged into master and branch-2.0. Saw some very minor issues. I make
another pass and fix them in a follow-up PR. Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user GayathriMurali commented on the issue:
https://github.com/apache/spark/pull/13285
@jkbradley I fixed for the review comment. Please let me know if there is
anything else. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/13285
This looks good, though I had one small comment. Thanks for your patience!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user GayathriMurali commented on the issue:
https://github.com/apache/spark/pull/13285
@yanboliang Please let me know if there is anything else I can do to help
get this merged.Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13285
**[Test build #3078 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3078/consoleFull)**
for PR 13285 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13285
**[Test build #3078 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3078/consoleFull)**
for PR 13285 at commit
Github user GayathriMurali commented on the issue:
https://github.com/apache/spark/pull/13285
@yanboliang Please let me know if there is anything else I can do to get
this merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13285
@GayathriMurali I think what is there for ```include_example``` is OK.
Please see my other inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user GayathriMurali commented on the issue:
https://github.com/apache/spark/pull/13285
Also, #10219 uses include_example with different files , which is not the
case here. @mengxr We need support for tags with include_example, or we need to
reformat ml.R( or split every
Github user GayathriMurali commented on the issue:
https://github.com/apache/spark/pull/13285
@yanboliang `$example on$` and `$example off$` needs to be included in
ml.R. All the code encompassed within example on and off would be joined and a
single code block will be produced in
10 matches
Mail list logo
